Add rolling function as options#1
Open
Japjappedulap wants to merge 2 commits into
Open
Conversation
A new option `rollingFunction` was added. This will determine if the cookie will be set on a request, similar to the `rolling` option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new option
rollingFunctionwas added. This will determine if the cookie will be set on a request, similar to therollingoption.Session are rolled by default only on the store, without their
.cookiebeing altered. On each request, a touch is made to the store, meaning that the object's expire is reseted and will live longer than the user's session, leading to different expire dates between the store and the user session. This behaviour has already been reported.Using
rollingwill set-cookie with the same session ID, but with reseted maxAge, this is the desired behaviour, as the session is extended and the expires are equal between the client and the server.Somehow, we need to be able to conditionally or manually roll sessions. This is where rollingFunction comes in handy.